Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DescribeBodyTerminal to DescribeAllTerminal #1178

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Add DescribeBodyTerminal to DescribeAllTerminal #1178

merged 1 commit into from
Feb 16, 2024

Conversation

arrudagates
Copy link
Contributor

This PR adds DescribeBodyTerminal to DescribeAllTerminal, keeping the local implementation of DescribeAllTerminal in sync with later versions of the Polkadot SDK, where DescribeBodyTerminal was introduced in-between versions 1.1.0 and 1.2.0.

For reference, this is the implementation in v1.2.0.

Dinonard
Dinonard approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Dinonard Dinonard added shiden related to shiden runtime shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels Feb 16, 2024
@Dinonard Dinonard merged commit 282485a into AstarNetwork:master Feb 16, 2024
3 of 5 checks passed
@ashutoshvarma ashutoshvarma mentioned this pull request Feb 27, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinonard Dinonard Dinonard approved these changes

Assignees
No one assigned
Labels
runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arrudagates @Dinonard