Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable tier slots calculation formula #1179

Merged
merged 6 commits into from
Mar 12, 2024

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Feb 16, 2024

Pull Request Summary

  • make slot number formula configurable per runtime
  • remove migration code from dApp staking v3 pallet

Discussion reference: https://forum.astar.network/t/dapp-staking-v3-on-shiden/6190

@Dinonard Dinonard added shiden related to shiden runtime astar Related to Astar shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels Feb 16, 2024
@Dinonard Dinonard marked this pull request as ready for review February 23, 2024 13:12
{
assert!(
init_tier_config.number_of_slots >= init_tier_config.slots_per_tier.iter().sum::<u16>() as u16,
"Safety check, sum of slots per tier must be equal or less than max number of slots (due to possible rounding)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this can be > ? Should we enforce = ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I've put it like that but forgot about the rounding, or flooring to be precise.

We might lose a slot per tier due to this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-02-23 at 15 36 37

PierreOssun
PierreOssun previously approved these changes Feb 23, 2024
Copy link

Code Coverage

Package Line Rate Branch Rate Health
pallets/static-price-provider/src 58% 0%
chain-extensions/xvm/src 0% 0%
pallets/unified-accounts/src 85% 0%
precompiles/xcm/src 73% 0%
primitives/src/xcm 65% 0%
pallets/astar-xcm-benchmarks/src 87% 0%
pallets/ethereum-checked/src 79% 0%
precompiles/assets-erc20/src 81% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/xvm/src 51% 0%
precompiles/unified-accounts/src 100% 0%
pallets/dapp-staking-migration/src 48% 0%
precompiles/dispatch-lockdrop/src 86% 0%
pallets/dapps-staking/src 89% 0%
pallets/inflation/src 83% 0%
precompiles/dapps-staking/src 93% 0%
pallets/block-rewards-hybrid/src 91% 0%
precompiles/xvm/src 74% 0%
pallets/xc-asset-config/src 64% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/dapp-staking-v3/src 91% 0%
pallets/collator-selection/src 91% 0%
chain-extensions/types/xvm/src 0% 0%
chain-extensions/pallet-assets/src 56% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/dapp-staking-v3/src/test 0% 0%
precompiles/dapp-staking-v3/src 90% 0%
precompiles/sr25519/src 64% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
primitives/src 62% 0%
chain-extensions/types/assets/src 0% 0%
pallets/dapp-staking-v3/src/benchmarking 99% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
pallets/dapps-staking/src/pallet 86% 0%
Summary 80% (4423 / 5535) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard Dinonard merged commit c267517 into master Mar 12, 2024
9 checks passed
@Dinonard Dinonard deleted the feat/slot-calculation-formula-update branch March 12, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants