Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove genesis state print #1235

Merged
merged 2 commits into from May 6, 2024
Merged

Conversation

ermalkaleci
Copy link
Contributor

@ermalkaleci ermalkaleci commented May 2, 2024

This genesis state generated is incorrect. If we don't need it then better remove it
closes #1234

@ermalkaleci ermalkaleci added the client This PR/Issue is related to the topic “client”. label May 2, 2024
@Dinonard
Copy link
Member

Dinonard commented May 2, 2024

Dumb question - why is it incorrect?

@ermalkaleci
Copy link
Contributor Author

Dumb question - why is it incorrect?

it's using state_version 1

@ashutoshvarma
Copy link
Member

@ermalkaleci How about hardcoding the state_verison here to V0, all parachains state_version was 0 in genesis anyways?

@ermalkaleci
Copy link
Contributor Author

@ermalkaleci How about hardcoding the state_verison here to V0, all parachains state_version was 0 in genesis anyways

Then it will be wrong for local and dev

Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I checked the code now so it's clear.

Good catch! 💪 😃

Copy link
Member

@ashutoshvarma ashutoshvarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it will be wrong for local and dev

@ermalkaleci
We don't print this for local (dev) since it's standalone chain. (nvm, still wrong for zombienet)

But as Dino said it's not useful anyways so let's remove it. Great find!

@ermalkaleci
Copy link
Contributor Author

@Dinonard didn't have gpg setup before so I can't merge this. Can you do it?

@Dinonard
Copy link
Member

Dinonard commented May 3, 2024

@Dinonard didn't have gpg setup before so I can't merge this. Can you do it?

Uh, no, they have to be signed. I don't have admin rights for the repo.

Can you force-push the signed commits?

Signed-off-by: Ermal Kaleci <ermalkaleci@gmail.com>
Signed-off-by: Ermal Kaleci <ermalkaleci@gmail.com>
@ermalkaleci ermalkaleci force-pushed the fix/remove-genesis-state-print branch from 798d87b to 980c06b Compare May 3, 2024 09:49
@ermalkaleci
Copy link
Contributor Author

@Dinonard didn't have gpg setup before so I can't merge this. Can you do it?

Uh, no, they have to be signed. I don't have admin rights for the repo.

Can you force-push the signed commits?

force-push works

Copy link

github-actions bot commented May 3, 2024

Code Coverage

Package Line Rate Branch Rate Health
chain-extensions/pallet-assets/src 56% 0%
pallets/dapp-staking-migration/src 0% 0%
precompiles/assets-erc20/src 81% 0%
pallets/dapp-staking-v3/src 92% 0%
precompiles/xvm/src 75% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/astar-xcm-benchmarks/src 88% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
pallets/collator-selection/src 92% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
precompiles/unified-accounts/src 100% 0%
chain-extensions/xvm/src 0% 0%
pallets/static-price-provider/src 52% 0%
chain-extensions/types/assets/src 0% 0%
pallets/inflation/src 83% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/xcm/src 73% 0%
pallets/dapp-staking-v3/src/test 0% 0%
precompiles/sr25519/src 64% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/dapp-staking-v3/src/benchmarking 99% 0%
pallets/ethereum-checked/src 79% 0%
pallets/price-aggregator/src 72% 0%
precompiles/dapp-staking-v3/src 90% 0%
primitives/src/xcm 64% 0%
pallets/oracle-benchmarks/src 0% 0%
chain-extensions/types/xvm/src 0% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
pallets/unified-accounts/src 86% 0%
precompiles/dispatch-lockdrop/src 86% 0%
pallets/xvm/src 54% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
primitives/src 61% 0%
pallets/xc-asset-config/src 64% 0%
Summary 78% (3599 / 4632) 0% (0 / 0)

Minimum allowed line rate is 50%

@ermalkaleci ermalkaleci merged commit 8a10a7b into master May 6, 2024
8 checks passed
@ermalkaleci ermalkaleci deleted the fix/remove-genesis-state-print branch May 6, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client This PR/Issue is related to the topic “client”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

print out incorrect genesis state
3 participants