Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shiden genesis sync #1242

Merged
merged 5 commits into from
May 16, 2024
Merged

fix shiden genesis sync #1242

merged 5 commits into from
May 16, 2024

Conversation

ermalkaleci
Copy link
Contributor

@ermalkaleci ermalkaleci commented May 13, 2024

Custom PendingCrateInherentDataProvider and AuraConsensusDataProvider implementation required by EVM RPC to support Shiden sync from genesis block when there was no AuraApi. The implementation returns error instead of panic

@ermalkaleci ermalkaleci added shiden related to shiden runtime client This PR/Issue is related to the topic “client”. labels May 13, 2024
@ermalkaleci ermalkaleci marked this pull request as ready for review May 13, 2024 21:18
Copy link
Member

@ashutoshvarma ashutoshvarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ermalkaleci can you add a brief PR summary for root cause, solution? thanks

bin/collator/src/rpc.rs Outdated Show resolved Hide resolved
bin/collator/src/rpc.rs Outdated Show resolved Hide resolved
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add to Ash's comment, please add a PR summary/description so it's clear what it's about. Thanks!

bin/collator/src/rpc.rs Outdated Show resolved Hide resolved
Dinonard
Dinonard previously approved these changes May 16, 2024
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Left one comment, but it's optional.
However, please add a PR summary before the merge. Thanks!

bin/collator/src/parachain/shell_upgrade.rs Outdated Show resolved Hide resolved
@ermalkaleci ermalkaleci merged commit d0aa30b into master May 16, 2024
9 checks passed
@ermalkaleci ermalkaleci deleted the fix/shiden-sync branch May 16, 2024 08:21
Copy link

Code Coverage

Package Line Rate Branch Rate Health
precompiles/dispatch-lockdrop/src 86% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
chain-extensions/types/assets/src 0% 0%
precompiles/assets-erc20/src 81% 0%
pallets/oracle-benchmarks/src 0% 0%
chain-extensions/xvm/src 0% 0%
pallets/dapp-staking-v3/src 92% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/price-aggregator/src 72% 0%
precompiles/dapp-staking-v3/src 90% 0%
pallets/dapp-staking-v3/src/benchmarking 99% 0%
precompiles/unified-accounts/src 100% 0%
precompiles/xcm/src 73% 0%
precompiles/xvm/src 75% 0%
precompiles/sr25519/src 64% 0%
pallets/xc-asset-config/src 64% 0%
primitives/src 61% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/ethereum-checked/src 79% 0%
pallets/inflation/src 83% 0%
precompiles/substrate-ecdsa/src 74% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/collator-selection/src 92% 0%
pallets/dapp-staking-migration/src 0% 0%
pallets/unified-accounts/src 86% 0%
pallets/xvm/src 54% 0%
primitives/src/xcm 64% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/dapp-staking-v3/src/test 0% 0%
pallets/astar-xcm-benchmarks/src 88% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
pallets/static-price-provider/src 52% 0%
Summary 78% (3599 / 4632) 0% (0 / 0)

Minimum allowed line rate is 50%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client This PR/Issue is related to the topic “client”. shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shiden - Thread 'main' panicked at 'slot_duration is always present
3 participants