Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pallet proxy to astar #926

Merged
merged 13 commits into from
Jun 2, 2023
Merged

Conversation

gitofdeepanshu
Copy link
Contributor

@gitofdeepanshu gitofdeepanshu commented May 5, 2023

Pull Request Summary

This PR adds pallet-proxy to Astar.

Added Proxy Types

    /// Allows all runtime calls for proxy account
    Any,
    
    /// Allows only NonTransfer runtime calls for proxy account
    /// To know exact calls check InstanceFilter implementation for ProxyTypes
    NonTransfer,
    
    /// All Runtime calls from Pallet Balances allowed for proxy account
    Balances,
    
    /// All Runtime calls from Pallet Assets allowed for proxy account
    Assets,
    
    /// Only provide_judgement call from pallet identity allowed for proxy account
    IdentityJudgement,
    
    /// Only reject_announcement call from pallet proxy allowed for proxy account
    CancelProxy,
    
    /// All runtime calls from pallet DappStaking allowed for proxy account
    DappsStaking,
    
    /// Only claim_staker call from pallet DappStaking allowed for proxy account
    StakerRewardClaim,

Check list

  • updated Astar official documentation
  • updated spec version
  • updated semver

@gitofdeepanshu gitofdeepanshu added the runtime This PR/Issue is related to the topic “runtime”. label May 5, 2023
@gitofdeepanshu gitofdeepanshu self-assigned this May 5, 2023
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move forward with this PR. 👍

Please update the spec version and semver too.

CancelProxy,
/// All runtime calls from pallet DappStaking allowed for proxy account
DappsStaking,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please extend it with the additional type for reward claiming?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do.

@gitofdeepanshu gitofdeepanshu marked this pull request as ready for review May 26, 2023 10:55
@gitofdeepanshu gitofdeepanshu added the astar Related to Astar label Jun 2, 2023
@gitofdeepanshu gitofdeepanshu merged commit 2655ac6 into master Jun 2, 2023
9 checks passed
@gitofdeepanshu gitofdeepanshu deleted the feat/pallet-proxy-astar branch June 2, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants