feat: add StakerRewardClaim proxy #934
Conversation
gitofdeepanshu
added
runtime
runtime/local/src/lib.rs
Outdated
| @@ -91,7 +91,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion { | |||
| spec_name: create_runtime_str!("local"), | |||
| impl_name: create_runtime_str!("local"), | |||
| authoring_version: 1, | |||
| spec_version: 1, | |||
| spec_version: 2, | |||
There was a problem hiding this comment.
We always keep this one on 1, given it's just local chain.
I agree, we have some tests for ProxyType on shiden and should include tests with every runtime change. |
Signed-off-by: Deepanshu Hooda <hoodaisdeepanshu@gmail.com>
Signed-off-by: Deepanshu Hooda <hoodaisdeepanshu@gmail.com>
gitofdeepanshu
force-pushed
the
feat/stakerRewardClaim-proxy
branch
from
d53373c
to
6444a31
Compare
| @@ -1929,3 +1937,256 @@ cumulus_pallet_parachain_system::register_validate_block! { | |||
| BlockExecutor = cumulus_pallet_aura_ext::BlockExecutor::<Runtime, Executive>, | |||
| CheckInherents = CheckInherents, | |||
| } | |||
| #[cfg(test)] | |||
There was a problem hiding this comment.
Nit-picky: a new line would be nice.
For the follow-up, I'd suggest creating an item to see how to build up on these runtime tests.
I'm not sure we should mock everything, this seems more appropriate for semi-live testing via RPC, as @shaunxw already suggested.
| } | ||
| ProxyType::StakerRewardClaim => { |
There was a problem hiding this comment.
Let's be consistent with the comments.
Either all should have them or none.
Also for the enum values - e.g. in Shiden we have enum comments, but in Shibuya and local we don't.
Pull Request Summary
Added a new proxy type StakerRewardClaim.
Only allows claim_staker call (and pallet-utility calls) to be executed.
This is less permissive than existing DappsStaking proxy type and is more appropriate for remote reward claim.
related to #856
Check list