Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate orml-xtokens into Shiden #944

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Integrate orml-xtokens into Shiden #944

merged 2 commits into from
Jun 1, 2023

Conversation

shaunxw
Copy link
Member

@shaunxw shaunxw commented May 26, 2023

Pull Request Summary

Integrate orml-xtokens into Shiden.

Config is the same with Shibuya runtime. Tests had been added in the Shibuya PR.

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • updated spec version
  • updated semver

@shaunxw shaunxw marked this pull request as ready for review May 26, 2023 12:11
@shaunxw shaunxw added shiden related to shiden runtime runtime This PR/Issue is related to the topic “runtime”. labels May 26, 2023
Dinonard
Dinonard approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaunxw shaunxw merged commit e5d79bb into master Jun 1, 2023
7 of 8 checks passed
@shaunxw shaunxw deleted the feat/xtokens-shiden branch June 1, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinonard Dinonard Dinonard approved these changes

@ashutoshvarma ashutoshvarma Awaiting requested review from ashutoshvarma

@gitofdeepanshu gitofdeepanshu Awaiting requested review from gitofdeepanshu

Assignees
No one assigned
Labels
runtime This PR/Issue is related to the topic “runtime”. shiden related to shiden runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shaunxw @Dinonard