-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge astar-frame #957
Merge astar-frame #957
Conversation
The CI checks look all passed, but actually the |
Minimum allowed line rate is |
Code coverage CI is fixed. Sometimes the clippy CI fails without any error, and re-run works. PR #954 has this same issue. My best guess is that the overall workflow run takes too long. IMO the CI time improvement can be done in another PR, probably using a self-host runner for time-consuming tasks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For the CI issue, let's follow-up with devops!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull Request Summary
"The Merge"
pallet-precompile-dapps-staking
crate naming is not consistent with other precompiles, so I changed it topallet-evm-precompile-dapps-staking
.astar-frame
is also merged intoastar
workflows.If you have pending PR in
astar-frame
, please migrate it toastar
repo after this one is merged. (Sorry for the inconvenience)Check list