Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate the Astar Portal for Japanese #1112

Merged
merged 21 commits into from Jan 9, 2024
Merged

Conversation

tksarah
Copy link
Contributor

@tksarah tksarah commented Jan 4, 2024

Pull Request Summary
I translated to Japanese on i18n/ja/index.ts for Astar Portal.
This PR is in accordance with the Astar Ecosystem task "Translate the Astar Portal and keep it up to date."

Describe what changes this pull request makes to the repository

The "src/i18n/ja/index.ts" is modified to translate in Japanese.

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

This PR changes for Astar Portal.
We would be able to change to Japanese on Astar Portal's settings with this PR.
The translation rate is approximately 97%. This is because there were some things that were difficult to translate into Japanese. Those word or sentence is left as is for now.

@Kahonnohak
Copy link
Contributor

Thank you for your help. I see lots of errors, they are all code formatting mistakes. Could you check them by running below.
Run yarn dev to see errors.
Run yarn lint --fix to fix errors
Screenshot 2024-01-08 at 09 02 56

@tksarah
Copy link
Contributor Author

tksarah commented Jan 8, 2024

Thank you for your review. @Kahonnohak
I have fixed the errors and then I confirmed "No issues found." by running "yarn dev".

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We plan to release this PR on Wednesday!

@tksarah
Copy link
Contributor Author

tksarah commented Jan 8, 2024

Additionaly also updated the two lines of index.ts that were updated in update #1108.

72 claimRewards:
73 'DApp ステーキング V3 は 2024 年初頭に登場します! 必ず報酬を受け取り、リリース日を楽しみにお待ちください。',

@Kahonnohak
Copy link
Contributor

@tksarah could you create the PR against the hotfix branch please?

@tksarah
Copy link
Contributor Author

tksarah commented Jan 8, 2024

I created a PR. How about this? @Kahonnohak

@Kahonnohak
Copy link
Contributor

ahh, I am sorry, it wasn't needed at all, so sorry I was thinking of something else, will release tomorrow

@impelcrypto impelcrypto merged commit 4718312 into AstarNetwork:main Jan 9, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants