Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UNQ transfers from Unique Network to Astar #1120

Merged
merged 1 commit into from Jan 10, 2024

Conversation

mrshiposha
Copy link
Contributor

Pull Request Summary

Fix transfer of UNQ from Unique Network to Astar.

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Fixes

Fixed xtokens.transfer currency ID argument.

Here is the link to astar-apps with the fix already applied: https://poc-apps.aku.uniquenetwork.dev/astar/assets.
20 UNQ was transferred using the astar-apps version from the link above. Subscan XCM Transfer Info.

The fix is required following the v10030070 Unique Network upgrade, which uses the collection ID type directly as CurrencyId.

The collection ID for the native asset (UNQ) is 0.

Copy link
Member

@impelcrypto impelcrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've tested and it worked.

Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@impelcrypto impelcrypto merged commit f299309 into AstarNetwork:main Jan 10, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants