Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tooltips to the remaining days #1148

Merged
merged 11 commits into from Jan 23, 2024
Merged

add tooltips to the remaining days #1148

merged 11 commits into from Jan 23, 2024

Conversation

ayumitk
Copy link
Contributor

@ayumitk ayumitk commented Jan 22, 2024 •
edited

Pull Request Summary

  • Added tooltips to the remaining days on the unbond panel
  • Changed text from "Unbond" to "Unlock" on the assets page

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Adds

Screenshot 2024-01-22 at 11 26 25 AM

Changes

Screenshot 2024-01-22 at 10 54 09 PM Screenshot 2024-01-22 at 10 58 08 PM Screenshot 2024-01-22 at 10 58 17 PM

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2024 •
edited

Visit the preview URL for this PR (updated for commit cb97b53):

https://astar-apps--pr1148-feat-staking-panel-t-mgbrjskl.web.app

(expires Tue, 30 Jan 2024 08:16:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@ayumitk ayumitk changed the title add staking panel tooltips add tooltips to the remaining days on the unbond panel Jan 22, 2024
@ayumitk ayumitk marked this pull request as ready for review January 23, 2024 07:03
@ayumitk ayumitk changed the title add tooltips to the remaining days on the unbond panel add tooltips to the remaining days Jan 23, 2024
Kahonnohak
Kahonnohak approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

bobo-k2
bobo-k2 approved these changes Jan 23, 2024
View reviewed changes
src/i18n/en-US/index.ts Outdated
stake: 'Stake',
move: 'Move',
index: 'Index',
chunk: 'Chunk',
unbondingAmount: 'Unbonding amount',
unlockingAmount: 'unlocking amount',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe to change to 'Unlocking amount'.
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobo-k2 Thank you! fixed in cb97b53

@ayumitk ayumitk merged commit 91d603e into main Jan 23, 2024
7 checks passed
@ayumitk ayumitk deleted the feat/staking-panel-tooltip branch January 23, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobo-k2 bobo-k2 bobo-k2 approved these changes

@Kahonnohak Kahonnohak Kahonnohak approved these changes

@impelcrypto impelcrypto impelcrypto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ayumitk @bobo-k2 @Kahonnohak @impelcrypto