Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sticky anchor links on the assets page #1149

Merged
merged 13 commits into from
Jan 29, 2024
Merged

Conversation

ayumitk
Copy link
Contributor

@ayumitk ayumitk commented Jan 23, 2024

Pull Request Summary

  • Added the sticky anchor links on the assets page
  • It appears only Shibuya for now

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Adds

Screenshot 2024-01-22 at 6 38 20 PM

Copy link

github-actions bot commented Jan 23, 2024

Visit the preview URL for this PR (updated for commit 677420c):

https://astar-apps--pr1149-feat-assets-page-hyp-kh6ve8jr.web.app

(expires Mon, 05 Feb 2024 07:39:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@Kahonnohak
Copy link
Contributor

Kahonnohak commented Jan 23, 2024

This is all great, lets not spend more time on this but just two points

  1. Please change the position just below the account. Main reason is if we had the tab next to Staking, the tab on Staking section doesn't have attention (since tab blue is bigger) so wanted to separate from it.
  2. Background: Gray1
  3. Please add the dark theme with the background colour: Navy 3
Screenshot 2024-01-23 at 15 46 27

@ayumitk
Copy link
Contributor Author

ayumitk commented Jan 23, 2024

@Kahonnohak Thank you for your review! I've updated all of them

@ayumitk ayumitk marked this pull request as ready for review January 23, 2024 23:18
Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Great work - we will update this tab and add notification next time.

src/components/assets/Account.vue Outdated Show resolved Hide resolved
@ayumitk ayumitk merged commit 906e40b into main Jan 29, 2024
6 of 7 checks passed
@ayumitk ayumitk deleted the feat/assets-page-hyper-links branch January 29, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants