Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Staking V3 Number of Participants #1159

Merged
merged 6 commits into from
Feb 1, 2024
Merged

feat: Staking V3 Number of Participants #1159

merged 6 commits into from
Feb 1, 2024

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Jan 29, 2024 •
edited

Pull Request Summary

Add the number of participants to our data section of the dapp staking page.
image

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

@gluneau gluneau requested a review from bobo-k2 January 29, 2024 15:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited

Visit the preview URL for this PR (updated for commit 1782ada):

https://astar-apps--pr1159-feat-stakingv3-total-csijye6i.web.app

(expires Wed, 07 Feb 2024 14:33:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@gluneau gluneau marked this pull request as ready for review January 29, 2024 21:33
bobo-k2
bobo-k2 requested changes Jan 30, 2024
View reviewed changes
src/staking-v3/components/data/DataList.vue Outdated Show resolved Hide resolved
src/staking-v3/logic/services/DappStakingService.ts Outdated Show resolved Hide resolved
src/staking-v3/store/mutations.ts Outdated Show resolved Hide resolved
src/staking-v3/hooks/useDapps.ts Outdated Show resolved Hide resolved
@gluneau gluneau requested a review from bobo-k2 January 30, 2024 16:05
@Kahonnohak
Copy link
Contributor

Thanks! Styling has been already updated sometime ago?

Could you add it in the next to era please?
Screenshot 2024-01-31 at 12 29 27

gluneau and others added 2 commits January 31, 2024 08:43
@gluneau
Merge branch 'main' into feat/stakingv3-total-participants
8f6c17c
@gluneau @bobo-k2
Handle removal of unregistered dApps from a node storage (#1155) (#1161)
1782ada 
* Handle removal of unregistered dApps from a note storage

* Map dapp id

Co-authored-by: Bobo <bobo.kovacevic@gmail.com>
@gluneau
Copy link
Contributor Author

gluneau commented Jan 31, 2024

Main has been merged in as well as hotfix.

image

Kahonnohak
Kahonnohak approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@gluneau gluneau merged commit 876710a into main Feb 1, 2024
6 of 7 checks passed
@gluneau gluneau deleted the feat/stakingv3-total-participants branch February 1, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobo-k2 bobo-k2 bobo-k2 approved these changes

@Kahonnohak Kahonnohak Kahonnohak approved these changes

@impelcrypto impelcrypto Awaiting requested review from impelcrypto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gluneau @Kahonnohak @bobo-k2