Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added lockdrop account UI #1166

Merged
merged 17 commits into from Feb 19, 2024
Merged

feat: added lockdrop account UI #1166

merged 17 commits into from Feb 19, 2024

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented Feb 6, 2024

Pull Request Summary

  • feat: added lockdrop account UI
    • The toggle button appears for the H160 account which mapped SS58 account has more than 0 native token
    • It works on Shibuya only for now. I'll update it once Astar and Shiden runtime have been updated. CC: @PierreOssun

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Adds

  • feat: added lockdrop account UI

image

image

image

Copy link

github-actions bot commented Feb 6, 2024

Visit the preview URL for this PR (updated for commit f4e7373):

https://astar-apps--pr1166-fix-lockdrop-account-krmzu7wu.web.app

(expires Thu, 22 Feb 2024 07:51:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@impelcrypto impelcrypto marked this pull request as ready for review February 14, 2024 07:18
@Kahonnohak
Copy link
Contributor

Kahonnohak commented Feb 14, 2024

tested, transaction works! great work!

  • The yellow box doesn't seemed to be applied on the UI
  • Could you add "Access ends 31 August 2024" on the yellow box please? If the text gets too long its fine to change the font size.
  • It might be better to take them to Asset page since most of them has staking balance they need unlocking first before they can move tokens
Screenshot 2024-02-14 at 10 53 24

@impelcrypto
Copy link
Member Author

impelcrypto commented Feb 15, 2024

@Kahonnohak

It might be better to take them to Asset page since most of them has staking balance they need unlocking first before they can move tokens

Do you mean the portal goes to assets page after users click Move Funds Now button? But then there is no point to have this button as the modal appears on the assets page.

@impelcrypto
Copy link
Member Author

@Kahonnohak Fixed in this commit.

image

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

@impelcrypto impelcrypto merged commit c477ad9 into main Feb 19, 2024
6 of 7 checks passed
@impelcrypto impelcrypto deleted the fix/lockdrop-account branch February 19, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants