Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll animation #1174

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Fix scroll animation #1174

merged 1 commit into from
Feb 9, 2024

Conversation

ayumitk
Copy link
Contributor

@ayumitk ayumitk commented Feb 8, 2024

Pull Request Summary

  • Fixed the background image scroll animation

It worked in the local env but didn't work after deployment to the server. Still, I don't know why this happened, but adding !important to CSS fixed it.

I'm using a new CSS property animation-timeline, and it works only on Chrome.

https://www.loom.com/share/b3738834bb18412e92270d831f748140?sid=446c5940-f801-43fe-b17b-7a11279e2b60

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

Copy link

github-actions bot commented Feb 8, 2024

Visit the preview URL for this PR (updated for commit cfff550):

https://astar-apps--pr1174-feat-fix-scroll-anim-76uoom8y.web.app

(expires Thu, 15 Feb 2024 17:21:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@ayumitk ayumitk changed the title scroll animation test Fix scroll animation Feb 8, 2024
@ayumitk ayumitk marked this pull request as ready for review February 8, 2024 17:42
Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ayumitk ayumitk merged commit 3db9951 into main Feb 9, 2024
6 of 7 checks passed
@ayumitk ayumitk deleted the feat/fix-scroll-animation branch February 9, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants