Don't batch a single call #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 64fa8b6): https://astar-apps--pr1184-fix-dont-batch-singl-rcaxdmgk.web.app (expires Tue, 20 Feb 2024 18:54:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
impelcrypto
requested changes
Feb 13, 2024
| @@ -397,7 +397,7 @@ export class DappStakingRepository implements IDappStakingRepository { | |||
| public async batchAllCalls(calls: ExtrinsicPayload[]): Promise<ExtrinsicPayload> { | |||
| const api = await this.api.getApi(); | |||
|
|
|||
| return api.tx.utility.batchAll(calls); | |||
| return calls.length == 1 ? calls[0] : api.tx.utility.batchAll(calls); | |||
There was a problem hiding this comment.
Suggested change
| return calls.length == 1 ? calls[0] : api.tx.utility.batchAll(calls); | |
| return calls.length === 1 ? calls[0] : api.tx.utility.batchAll(calls); |
There was a problem hiding this comment.
Thanks, fixed in f0b1042
|
@bobo-k2 could we add unstoppable image on this PR? |
impelcrypto
approved these changes
Feb 14, 2024
impelcrypto
pushed a commit
that referenced
this pull request
Feb 16, 2024
* Enable dApp staking v3 on Astar (#1182) * Add text ellipsis to the dApp cards (#1186) * add text ellipsis to the dapp card * update * Revert "update" This reverts commit 29c7d3f. * fix the arrow style of the ads section * fix builders card layout * fix dapp page short description * Don't batch a single call (#1184) * Don't batch a single call * Ubstoppable grants background * Min staking amount warning condition fix * Code review update * Category title padding fix * Fix for min staking amount warning (#1191) --------- Co-authored-by: Ayumi Takahashi <ayumee528@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR contains the following:
Check list