Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable sending bridge transactions when Gelato API is down #1194

Merged
merged 3 commits into from Feb 28, 2024
Merged

fix: disable sending bridge transactions when Gelato API is down #1194

merged 3 commits into from Feb 28, 2024

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented Feb 19, 2024 •
edited

Pull Request Summary

  • fix: disable sending bridge transactions when Gelato API is down

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Changes

  • fix: disable sending bridge transactions when Gelato API is down

Display the error toast
image

Disable the button
image

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2024 •
edited

Visit the preview URL for this PR (updated for commit c175817):

https://astar-apps--pr1194-fix-bridge-maintenan-s3mewoi0.web.app

(expires Tue, 05 Mar 2024 13:39:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@Kahonnohak Kahonnohak self-requested a review February 19, 2024 13:44
Kahonnohak
Kahonnohak approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gluneau
gluneau approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended

@impelcrypto impelcrypto merged commit 08d9238 into main Feb 28, 2024
8 of 9 checks passed
@impelcrypto impelcrypto deleted the fix/bridge-maintenance branch February 28, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gluneau gluneau gluneau approved these changes

@Kahonnohak Kahonnohak Kahonnohak approved these changes

@bobo-k2 bobo-k2 Awaiting requested review from bobo-k2

@ayumitk ayumitk Awaiting requested review from ayumitk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@impelcrypto @gluneau @Kahonnohak