feat: support zkEVM mainnet #1208
Conversation
impelcrypto
requested review from
ayumitk,
bobo-k2,
gluneau and
Kahonnohak
and removed request for
ayumitk
|
Visit the preview URL for this PR (updated for commit f9da926): https://astar-apps--pr1208-feat-astar-zkevm-mai-g5fe7u46.web.app (expires Wed, 13 Mar 2024 02:45:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
| @@ -21,32 +22,33 @@ import { astarNativeTokenErcAddr } from 'src/modules/xcm'; | |||
| type MerkleProof = { | |||
| main_exit_root: string; | |||
| merkle_proof: string[]; | |||
| rollup_merkle_proof: string[]; | |||
| // Todo: remove '?' | |||
| rollup_merkle_proof?: string[]; | |||
There was a problem hiding this comment.
@impelcrypto what should occur so that you can remove the ?
There was a problem hiding this comment.
This key doesn't exist in zKatana's API but zKyoto and mainnet. So we should remove ? when we migrate the testnet to zKyoto
|
|
||
| const abi = isAggregateContract ? ZK_EVM_AGGREGATED_BRIDGE_ABI : ZK_EVM_BRIDGE_ABI; | ||
| // ABI: https://github.com/0xPolygonHermez/zkevm-bridge-ui/blob/7c84791d06770569d316f27d62c3989bef81be58/abis/bridge.json |
There was a problem hiding this comment.
Should we keep these comments in? Do they serve a purpose?
There was a problem hiding this comment.
Because I can't find the ABI on Etherscan. Perhaps I should update the comment to point at the main branch.
https://etherscan.io/address/0x2a3dd3eb832af982ec71669e178424b10dca2ede#code
… into feat/astar-zkevm-mainnet
* fix: enabled withdrawal * fix: clean up
Pull Request Summary
Check list
This pull request makes the following changes:
Adds