Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor workflows #1266

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Refactor workflows #1266

merged 2 commits into from
Apr 24, 2024

Conversation

gtg7784
Copy link
Member

@gtg7784 gtg7784 commented Apr 24, 2024

Pull Request Summary

Update Deploy to Release hotfix-S3 to trigger push event in release-hotfix branch. disable workflows that isn't using anymore.

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Changes

  • Update Deploy to Release hotfix-S3 to trigger push event in release-hotfix branch.
  • Disable workflows that is not using recently. Update disabled workflow's filename to add _ in prefix, also add .disabled postfix

impelcrypto
impelcrypto approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@impelcrypto impelcrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's see if this works

@github-actions GitHub Actions
Copy link

Visit the preview URL for this PR (updated for commit f8eb1fc):

https://astar-apps--pr1266-refactor-workflows-eq4y3llu.web.app

(expires Wed, 01 May 2024 04:59:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

ehsanhajian
ehsanhajian approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@ehsanhajian ehsanhajian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gtg7784 gtg7784 merged commit 4dc2fa8 into main Apr 24, 2024
9 checks passed
@gtg7784 gtg7784 deleted the refactor/workflows branch April 24, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsanhajian ehsanhajian ehsanhajian approved these changes

@impelcrypto impelcrypto impelcrypto approved these changes

@bobo-k2 bobo-k2 Awaiting requested review from bobo-k2

@ayumitk ayumitk Awaiting requested review from ayumitk

@Kahonnohak Kahonnohak Awaiting requested review from Kahonnohak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gtg7784 @ehsanhajian @impelcrypto