Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: total USD amount for lockdrop account #1274

Merged
merged 1 commit into from Apr 26, 2024
Merged

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented Apr 26, 2024

Pull Request Summary

  • fix: total USD amount for lockdrop account
  • fix: hide the lockdrop toggle on Astar zkEVM

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Fixes

  • fix: total USD amount for lockdrop account

=Before=

image

=After=
image

() => Number(balUsd.value) + props.ttlErc20Amount + props.ttlNativeXcmUsdAmount
);
const totalBal = computed<number>(() => {
const addAmount = isH160.value ? props.ttlErc20Amount : props.ttlNativeXcmUsdAmount;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is the reason.. thank you roy!

Copy link

Visit the preview URL for this PR (updated for commit c84707b):

https://astar-apps--pr1274-fix-usd-amount-lockd-fyyszit5.web.app

(expires Fri, 03 May 2024 13:53:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@impelcrypto impelcrypto merged commit b66387d into main Apr 26, 2024
8 of 9 checks passed
@impelcrypto impelcrypto deleted the fix/usd-amount-lockdrop branch April 26, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants