Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add native bridge deposit warning banner (#1275)" #1276

Merged
merged 1 commit into from
May 1, 2024

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Apr 30, 2024

This reverts commit fe186dc.

Pull Request Summary

Re-enable bridge deposit

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

Copy link

Visit the preview URL for this PR (updated for commit 8c66f2b):

https://astar-apps--pr1276-fix-revert-disable-b-856xya9p.web.app

(expires Tue, 07 May 2024 21:08:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@ayumitk ayumitk self-requested a review April 30, 2024 23:14
Copy link
Contributor

@ayumitk ayumitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@gtg7784 gtg7784 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtg7784 gtg7784 merged commit c547cf6 into release-hotfix May 1, 2024
5 of 6 checks passed
@gtg7784 gtg7784 deleted the fix/revert-disable-bridge branch May 1, 2024 01:14
impelcrypto added a commit that referenced this pull request May 14, 2024
* add native bridge deposit warning banner (#1275)

* add native bridge deposit warning banner

* update warning text on native bridge

* disable desposit button on bridge

* update i18n warning variable naming

* Revert "add native bridge deposit warning banner (#1275)" (#1276)

* fix: enables unlock and withdrawal from Lockdrop accounts (#1279)

* feat: updated unlock logic

* fix: updated dApp staking logic for Lockdrop accounts

* Revert "fix: updated dApp staking logic for Lockdrop accounts"

This reverts commit 0c00f9c.

* Revert "feat: updated unlock logic"

This reverts commit 4a38747.

* fix: simlifize the logic

* fix: moved variable for ETHEREUM_EXTENSION

* update withdrawal warning 20h -> 5h (#1284)

* fix: updating lockdrop contract address for Shiden (#1285)

---------

Co-authored-by: Alan <tae.gun7784@gmail.com>
Co-authored-by: Bobo <bobo.kovacevic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants