Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabled scrolling on input #1286

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented May 14, 2024

Pull Request Summary

  • fix: disabled scrolling on input

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Fixes

Copy link

Visit the preview URL for this PR (updated for commit d5629f8):

https://astar-apps--pr1286-fix-disable-scroll-o-a5baz684.web.app

(expires Tue, 21 May 2024 09:05:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

Copy link
Member

@gtg7784 gtg7784 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have a feeling that we should create input component and re-use it in other components. This is not for this PR but in general. What do you think?

@impelcrypto
Copy link
Member Author

I have a feeling that we should create input component and re-use it in other components. This is not for this PR but in general. What do you think?

Actually, I agree, we should have a common input component.

@impelcrypto impelcrypto merged commit d639606 into main May 15, 2024
9 checks passed
@impelcrypto impelcrypto deleted the fix/disable-scroll-on-input branch May 15, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants