Improve getDapp method error handling #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 17ce355): https://astar-apps--pr1307-fix-get-dapp-error-h-exsuvf5p.web.app (expires Thu, 13 Jun 2024 12:41:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
impelcrypto
approved these changes
Jun 6, 2024
bobo-k2
added a commit
that referenced
this pull request
Jun 13, 2024
* Ledger dApp Staking V3 Promotion Card (#1304) * Ledger dApp Staking v3 promotion card to dApp Staking page - Add Ledger dApp Staking v3 banner to image folder - Update dapp_promtions.json file * Update dapp_promotions.json * Update dapp_promotions.json * Update dapp_promotions.json * dApp staking banner text update (#1308) * dApp staking banner text update * Banner text update * Improve getDapp method error handling (#1307) * fix recent history link for zkevm (#1312) * fix recent history link for zkevm * remove useless console.log * remove XCM txs in getZkEVMTxHistories function * refactor castTransferHistory function * hotfix: disabling xcm for Shiden (#1313) --------- Co-authored-by: Gaius_sama <85451570+Gunit2481@users.noreply.github.com> Co-authored-by: Taegeon Alan Go <tae.gun7784@gmail.com> Co-authored-by: Roy <92044428+impelcrypto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Fixed error 404 handling for
getDappmethodCheck list