feat: added 'total claimed rewards' amount on 'Your Rewards' panel #376
Conversation
|
Visit the preview URL for this PR (updated for commit 1c81a21): https://astar-apps--pr376-feat-earned-rewards-stpkw3yy.web.app (expires Sun, 15 May 2022 16:58:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
| </div> | ||
| <div class="container--panel"> | ||
| <value-panel title="Total Supply" :value="totalSupply" /> | ||
| <rewards-panel :symbol="chainInfo.tokenSymbol" /> |
There was a problem hiding this comment.
if we plan to add this view on the dApps Staking page at some point, I don't think it makes sense to add this on the dashboard page now?
What are your thoughts @Kahonnohak ?
There was a problem hiding this comment.
Yes this needs to be on dApp Staking. i just commented on Slack. The question is how much we are adding before we can move to V2. V1 just got "your rewards' section which is appropriate for showing the total earned rewards however the space is tight and will need additional frontend development which is pitty..) Let me think.
The total Earned display makes good encouragement to users indeed and is amazing, however, the ideal goal is to have the total earned per project not all-time.
There was a problem hiding this comment.
Fixed in this commit
impelcrypto
changed the title
impelcrypto
changed the title
|
Hi!
|
Fixed :) |
Pull Request Summary
total claimed rewardsamount on 'Your Rewards' panelcurrent circulatingandtotal circulatingsupply) into one panelholderspanel on the dashboard pagewaitfunction instead ofsetTimeoutCheck list
This pull request makes the following changes:
Adds