Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration ui components - drawer and radio button #379

Merged
merged 6 commits into from May 6, 2022
Merged

Conversation

sirius651
Copy link
Contributor

@sirius651 sirius651 commented May 3, 2022

Pull Request Summary

Describe what changes this pull request makes to the repository

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes

This pull request makes the following changes:
Modal-drawer , Radio-button, Spinner
with v0.0.35

@github-actions
Copy link

github-actions bot commented May 3, 2022

Visit the preview URL for this PR (updated for commit 7a5007b):

https://astar-apps--pr379-migrate-ui-lib-6ajm2d7d.web.app

(expires Thu, 12 May 2022 01:42:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Contributor

@hoonsubin hoonsubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoonsubin hoonsubin changed the title Migration ui components Migration ui components - drawer and radio button May 3, 2022
Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sirius651 sirius651 merged commit 422432d into main May 6, 2022
@sirius651 sirius651 deleted the migrate/ui-lib branch May 6, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants