Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connecting wallet using firefox #386

Merged
merged 3 commits into from
May 6, 2022
Merged

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented May 6, 2022

Pull Request Summary

  • fix: connecting wallet using Firefox

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes

This pull request makes the following changes:

Fixes

  • (ex: Fix validation function)

Firefox takes some time to load the wallet extensions at the boot time.

=Before=

image

=After=

image

@github-actions
Copy link

github-actions bot commented May 6, 2022

Visit the preview URL for this PR (updated for commit 03745c4):

https://astar-apps--pr386-fix-wallet-firefox-gd7um6a7.web.app

(expires Fri, 13 May 2022 10:18:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

src/config/api/polkadot/connectApi.ts Outdated Show resolved Hide resolved
@impelcrypto impelcrypto marked this pull request as ready for review May 6, 2022 10:20
Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hoonsubin hoonsubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@impelcrypto impelcrypto merged commit 163b18e into main May 6, 2022
@impelcrypto impelcrypto deleted the fix/wallet-firefox branch May 6, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants