-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SubWallet] Enable Mobile version #639
[SubWallet] Enable Mobile version #639
Conversation
Hello @impelcrypto, we are preparing the necessary information for the integration here Koniverse/SubWallet-Mobile#297. I'm wondering if we can pass the PR without having to test out every case mentioned in the doc ? To be specific, we are having trouble getting some tokens to test out every case. We see that the Portal only requests signature from the wallet to submit transaction so technically we don't need to test with every single type of token. SubWallet Mobile works just like SubWallet extension so we are sure it doesn't bring any strange behavior to the Portal. SubWallet extension has been working well on Astar Portal for over a year so i think it would be fine. Plus, i see that the there was only 1 commit and it was just about changing some configurations. |
Which tokens you are having trouble for testing? I can't approve this PR without testing. Also please deploy this this branch to somewhere like Vercel, so that our team can test the functions. |
Here are the resources of the testing that we've done We have not found ways to test out these cases (mainly because we currently don't have the corresponding tokens):
Do we have to try out every single case ? Since some cases are similar and it would take us a while to get tokens cc @impelcrypto |
Thank you, I'll test it out tomorrow.
|
Thank you |
Here is the deployment link: Vercel |
It's working correctly on the device that we use, here are the videos of the test cases. Can you test it with another device perhaps ? Device: Xiaomi Mi 8 Lite - Android 10 |
@sirius651 @Kahonnohak @bobo-k2 @hoonsubin @togamamora @gluneau @niklabh
I'd like to seek your help for testing SubWallet mobile app on our portal especially for Android. Staging URL: https://astar-portal-wheat.vercel.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested on iOS. LGTM
@NamPhamc99 Hi, regarding android, is this only for extension? not native app? |
Hi @sirius651, i'm not sure i understand your question. Can you be more specific ? |
@sirius651 If I understand correctly, we can test it on the Android native app. |
yes you can download it from Play Store to test it out if you want |
Approved. confirmed that works well on android |
Hello @impelcrypto, is there any new update regarding this PR ? Do we have to wait for the other 5 reviewers to approve ? |
Hi @NamPhamc99, I've merged this PR. Please take note that we are going to deploy the latest main branch to the production page (https://portal.astar.network/) next Monday. |
Thank you @impelcrypto |
Pull Request Summary
This is the pull request I have created for the integration of our SubWallet mobile into the Astar portal. Please merge.
Change