Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates Polkadot.js packages #830

Merged
merged 7 commits into from
Jun 22, 2023
Merged

feat: updates Polkadot.js packages #830

merged 7 commits into from
Jun 22, 2023

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented Jun 12, 2023

Pull Request Summary

  • feat: updates Polkadot.js packages

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Changes

  • feat: updates Polkadot.js packages

To-dos

  • [Resolved] Resolve unknown errors

    • it seems removing this line helps resolving one of errors, but I don't think this is the root cause.
  • Resolve test (yarn test)

image

image

@github-actions
Copy link

github-actions bot commented Jun 12, 2023

Visit the preview URL for this PR (updated for commit 7335789):

https://astar-apps--pr830-feat-update-polkadot-2fpbbn2k.web.app

(expires Tue, 27 Jun 2023 02:34:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@sirius651
Copy link
Contributor

when I debug this, regarding @polkadot/x-textdecoder issue, that comes from import { BN } from '@polkadot/util';. maybe we can resolve by replacing BN from alternatives?

@impelcrypto
Copy link
Member Author

when I debug this, regarding @polkadot/x-textdecoder issue, that comes from import { BN } from '@polkadot/util';. maybe we can resolve by replacing BN from alternatives?

@sirius651 I think that Polkadot.js packages require importing BN from '@polkadot/util' package (as @bobo-k2 explained in slack) but you can try.

@sirius651
Copy link
Contributor

when I debug this, regarding @polkadot/x-textdecoder issue, that comes from import { BN } from '@polkadot/util';. maybe we can resolve by replacing BN from alternatives?

@sirius651 I think that Polkadot.js packages require importing BN from '@polkadot/util' package (as @bobo-k2 explained in slack) but you can try.

import { BN } from '@polkadot/util'
unfortunately, there are so many places this code can be utilized on all services, repositories. I wanted to get idea from @bobo-k2

@impelcrypto impelcrypto marked this pull request as ready for review June 20, 2023 02:52
Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests run well, the code looks good.

@impelcrypto impelcrypto merged commit 813d6fa into main Jun 22, 2023
6 checks passed
@impelcrypto impelcrypto deleted the feat/update-polkadot branch June 22, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants