Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable each items on on-chain-data board #838

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Conversation

sirius651
Copy link
Contributor

@sirius651 sirius651 commented Jun 16, 2023

Pull Request Summary

Clickable each items on on-chain-data board

스크린샷 2023-06-16 오후 4 26 24

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

@sirius651
Copy link
Contributor Author

after reviewing design QA, will write e2e test

@github-actions
Copy link

github-actions bot commented Jun 16, 2023

Visit the preview URL for this PR (updated for commit 10d6576):

https://astar-apps--pr838-fix-onchaindata-boar-p47tjli8.web.app

(expires Tue, 27 Jun 2023 04:47:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@Kahonnohak
Copy link
Contributor

Cool!

  • Could you change the status of the background only when hover please? So no button colour is seen when you first look at and appears when hover?

  • Could you navigate to project pages rather than the staking page please?

@sirius651
Copy link
Contributor Author

Cool!

  • Could you change the status of the background only when hover please? So no button colour is seen when you first look at and appears when hover?
  • Could you navigate to project pages rather than the staking page please?

Fixed in this commit

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@sirius651 sirius651 merged commit f1a7a55 into main Jun 21, 2023
6 checks passed
@sirius651 sirius651 deleted the fix/onchaindata-board branch June 21, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants