Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display select-able account on ‘Account Drawer’ after granting authorisation on wallet extensions #889

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented Aug 1, 2023

Pull Request Summary

  • fix: display select-able account on ‘Account Drawer’ after granting authorisation on wallet extensions(for first time visitors)
    • removed duplicated requestExtensionsIfFirstAccess function which is the same function called in another hooks prior to openModalAccount.ts

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Fixes
=Before=
image

=After=
image

@impelcrypto impelcrypto changed the title * fix: display select-able account on 'Account Drawer' after granting authorization on wallet exntensions fix: display select-able account on 'Account Drawer' after granting authorization on wallet exntensions Aug 1, 2023
@impelcrypto impelcrypto changed the title fix: display select-able account on 'Account Drawer' after granting authorization on wallet exntensions fix: display select-able account on ‘Account Drawer’ after granting authorisation on wallet extensions Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Visit the preview URL for this PR (updated for commit f2a4e87):

https://astar-apps--pr889-fix-connect-wallet-sfam6h5n.web.app

(expires Tue, 08 Aug 2023 14:55:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@impelcrypto impelcrypto marked this pull request as ready for review August 1, 2023 10:53
Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

Copy link
Contributor

@ayumitk ayumitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@impelcrypto impelcrypto merged commit b1688c4 into main Aug 2, 2023
6 checks passed
@impelcrypto impelcrypto deleted the fix/connect-wallet branch August 2, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants