Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: updated clickDisclaimerButton function for the new disclaimer modal #897

Merged
merged 3 commits into from
Aug 15, 2023
Merged

test: updated clickDisclaimerButton function for the new disclaimer modal #897

merged 3 commits into from
Aug 15, 2023

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented Aug 14, 2023 •
edited

Pull Request Summary

  • test: updated clickDisclaimerButton function for the new disclaimer modal

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:
image

@github-actions
Copy link

github-actions bot commented Aug 14, 2023 •
edited

Visit the preview URL for this PR (updated for commit 35c48ae):

https://astar-apps--pr897-fix-update-disclaime-of6jjz9x.web.app

(expires Tue, 22 Aug 2023 00:14:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@impelcrypto impelcrypto changed the title test: updated clickDisclaimerButton function test: updated clickDisclaimerButton function for the new disclaimer modal Aug 14, 2023
@impelcrypto impelcrypto marked this pull request as ready for review August 14, 2023 14:16
gluneau
gluneau approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works as intended

@gluneau
fix dappstaking register (#898)
4155cbb
@gluneau
Fix/test disclaimer (#899)
35c48ae 
* fix dappstaking register

* more disclaimers
ayumitk
ayumitk approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@ayumitk ayumitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gluneau gluneau merged commit 40932af into main Aug 15, 2023
6 checks passed
@gluneau gluneau deleted the fix/update-disclaimer-button branch August 15, 2023 00:58
@gluneau gluneau mentioned this pull request Aug 16, 2023
Merged
7 tasks
gluneau added a commit that referenced this pull request Aug 16, 2023
@gluneau @impelcrypto
test: updated clickDisclaimerButton function for the new disclaimer m…
3ea216c 
…odal (#897) (#901)

* test: updated clickDisclaimerButton function

* fix dappstaking register (#898)

* Fix/test disclaimer (#899)

* fix dappstaking register

* more disclaimers

---------

Co-authored-by: impelcrypto <92044428+impelcrypto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gluneau gluneau gluneau approved these changes

@ayumitk ayumitk ayumitk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@impelcrypto @gluneau @ayumitk