Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added fallback API endpoints for parachains #911

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

impelcrypto
Copy link
Member

@impelcrypto impelcrypto commented Aug 29, 2023

Pull Request Summary

  • feat: added fallback API endpoints for parachains
  • fix: removed 'customEndpoint' value from local storage and Vuex state

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Adds

  • feat: added fallback API endpoints for parachains

Screenshot 2023-08-31 at 11 42 01 AM

Changes

  • fix: removed 'customEndpoint' value from local storage and Vuex state

@github-actions
Copy link

github-actions bot commented Aug 29, 2023

Visit the preview URL for this PR (updated for commit 42d7582):

https://astar-apps--pr911-feat-xcm-api-refacto-rteegqf3.web.app

(expires Thu, 07 Sep 2023 03:56:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@impelcrypto impelcrypto marked this pull request as ready for review August 31, 2023 09:35
Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works.

Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@impelcrypto impelcrypto merged commit 9f5e65c into main Sep 14, 2023
6 checks passed
@impelcrypto impelcrypto deleted the feat/XCM-api-refactoring branch September 14, 2023 11:39
bobo-k2 pushed a commit that referenced this pull request Oct 3, 2023
* wip: refactored connecting api logic to add fallback endpoints

* feat: updated endpoints

* feat: endpoint

* feat: removed customEndpoint from localstorage and global state

* fix: added console.info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants