Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapps loading optimizations #927

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Dapps loading optimizations #927

merged 2 commits into from
Sep 19, 2023

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Sep 13, 2023

Pull Request Summary

Modified portal use new dapps endpoints. Now portal loading time should be much faster.

BEFORE

  • load all dapps with all details from Token API on portal start
  • when users clicks a dApp get data from app storage (Vuex)

AFTER

  • on portal start load only dApps data required for dapps staking homepage (name, contract address, logo url and main category)
  • when user clicks a dApp load complete dapp details from Token API and store details to Vuex

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Visit the preview URL for this PR (updated for commit e917458):

https://astar-apps--pr927-feat-dapps-endpoint-2ye81zhd.web.app

(expires Thu, 21 Sep 2023 08:54:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@bobo-k2 bobo-k2 marked this pull request as ready for review September 14, 2023 07:26
Copy link
Member

@impelcrypto impelcrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to update styling when the app is loading (doesn't matter which PR)
image

Copy link
Member

@impelcrypto impelcrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JPYC (Shiden) doesn't display text on Project Overview

=Staging=
image

=Production=
image

@bobo-k2
Copy link
Contributor Author

bobo-k2 commented Sep 14, 2023

JPYC (Shiden) doesn't display text on Project Overview

Fixed here

@bobo-k2
Copy link
Contributor Author

bobo-k2 commented Sep 14, 2023

We might want to update styling when the app is loading (doesn't matter which PR)

Something more effective would be nice. What do you think @Kahonnohak?

Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the change in the API endpoint being used.

Good improvement in the way the Dapp is fetched, making it more dynamic and adaptable to different network settings.

@bobo-k2 bobo-k2 merged commit 4f5b7f7 into main Sep 19, 2023
6 checks passed
@bobo-k2 bobo-k2 deleted the feat/dapps-endpoint branch September 19, 2023 13:48
bobo-k2 added a commit that referenced this pull request Oct 3, 2023
* Dapps loading optimizations

* Fetch dApp from the proper network
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants