Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT ink! tutorial #197

Merged
merged 25 commits into from
Jan 16, 2023
Merged

DRAFT ink! tutorial #197

merged 25 commits into from
Jan 16, 2023

Conversation

PierreOssun
Copy link
Member

No description provided.

@PierreOssun PierreOssun requested a review from a team December 8, 2022 16:48
@PierreOssun PierreOssun requested a review from a team as a code owner December 8, 2022 16:48
@PierreOssun PierreOssun marked this pull request as draft December 8, 2022 16:49
@github-actions
Copy link

github-actions bot commented Dec 8, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit 5f94f44):

https://astar-docs--pr197-ink-builder-guide-mvc6m7jk.web.app

(expires Sun, 22 Jan 2023 20:04:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d

bobo-k2
bobo-k2 requested changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. I went through the tutorial and found and commented some points that could be improved.

docs/builder-guides/from- zero-to-ink-hero/dex/uniswap-v2-dex-in-ink.md Outdated Show resolved Hide resolved
docs/builder-guides/from- zero-to-ink-hero/dex/Pair/burn.md Outdated Show resolved Hide resolved
docs/builder-guides/from- zero-to-ink-hero/dex/Pair/psp22.md Outdated Show resolved Hide resolved
docs/builder-guides/from- zero-to-ink-hero/dex/Pair/psp22.md Show resolved Hide resolved
docs/builder-guides/from- zero-to-ink-hero/dex/Pair/storage.md Outdated Show resolved Hide resolved
docs/builder-guides/from- zero-to-ink-hero/dex/Factory/factory.md Outdated Show resolved Hide resolved
docs/builder-guides/from- zero-to-ink-hero/dex/Factory/factory.md Outdated Show resolved Hide resolved
docs/builder-guides/from- zero-to-ink-hero/dex/Factory/factory.md Outdated Show resolved Hide resolved
docs/builder-guides/from- zero-to-ink-hero/dex/Factory/factory.md Outdated Show resolved Hide resolved
docs/builder-guides/from- zero-to-ink-hero/dex/Factory/factory.md Outdated Show resolved Hide resolved
@Maar-io
Copy link
Member

Maar-io commented Jan 6, 2023

chapters before block code are sometimes ending with : and sometimes without it. Can you make it consistent?

@Maar-io
Copy link
Member

Maar-io commented Jan 6, 2023

OpenBrush, openbrush or Openbrush?

@Maar-io
Copy link
Member

Maar-io commented Jan 6, 2023

Can you add some light into why data::<MyType>() is called as function

@PierreOssun
Copy link
Member Author

PierreOssun commented Jan 9, 2023 •
edited
Loading

@Maar-io

Can you add some light into why data::() is called as function

Explanation is here:
https://github.com/Supercolony-net/openbrush-contracts/blob/e366f6ff1e5892c6a624833dd337a6da16a06baa/lang/src/traits.rs#L63

I think this is really advanced Rust and will not bring value for a tutorial. But advanced developer will check the Trait anyway if they need to understand

@fiexer fiexer marked this pull request as ready for review January 15, 2023 18:36
bobo-k2
bobo-k2 approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PierreOssun PierreOssun merged commit 253d33f into main Jan 16, 2023
@PierreOssun PierreOssun deleted the ink-builder-guide branch January 16, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maar-io Maar-io Maar-io left review comments

@bobo-k2 bobo-k2 bobo-k2 approved these changes

@fiexer fiexer fiexer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PierreOssun @Maar-io @bobo-k2 @fiexer