Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework complete Build chapter #253

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Rework complete Build chapter #253

merged 2 commits into from
Feb 14, 2023

Conversation

Maar-io
Copy link
Member

@Maar-io Maar-io commented Feb 8, 2023

No description provided.

@Maar-io Maar-io marked this pull request as ready for review February 8, 2023 14:17
@Maar-io Maar-io requested a review from a team February 8, 2023 14:17
@Maar-io Maar-io requested a review from a team as a code owner February 8, 2023 14:17
@Maar-io Maar-io marked this pull request as draft February 8, 2023 14:31
@Maar-io Maar-io changed the base branch from main to megan_DocsEdit February 8, 2023 18:40
@Maar-io Maar-io force-pushed the feature/build-revamp branch 2 times, most recently from be17d69 to 7e79d4e Compare February 9, 2023 07:37
@Maar-io Maar-io marked this pull request as ready for review February 9, 2023 21:18
@github-actions
Copy link

github-actions bot commented Feb 10, 2023

Visit the preview URL for this PR (updated for commit ad14b5e):

https://astar-docs--pr253-feature-build-revamp-pmtd9lbu.web.app

(expires Mon, 20 Feb 2023 19:50:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d

Copy link
Member

@andabak andabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Polkadot Overview page- docs/build/Introduction/polkadot_relay.md- is really good, but now feels redundant with Ecosystem/Polkadot stuff

Since this is builder perspective - I guess Ecosystem subpages should be reworked to adjust (and rererence this doc when appropriate)

@@ -56,7 +56,7 @@ You can see the full list of the command options using the `help` subcommand:
# ...
```

When you have successfully lauched the local network, you will see the following messages in your terminal:
When you have successfully launched the local network, you will see the following messages in your terminal:

![1](img/1.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used image here is wrong.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!!! Thanks. Please check

Base automatically changed from megan_DocsEdit to main February 13, 2023 14:49
evm shuffle

fix broken links

burn.md fix

moved Intergation Tooling section back to Root due to Megan's changes

fix relative links

more links broken

more broken links

this is an empty commit

test link

remaning buid_environment

removed underscore in folder name

removing funny links

liiinks

remove md from link

new changes by Megan

ready for review

preliminary edits to introduction and build environment sections

Temporary disable of translations (i18n) so the site can be build

Fix a typo. Added nav bar shortcut.

added banners

use user guide for account creation

add RPC info

Merged two ink! environment pages (#264)

updated links (#265)
@fiexer fiexer self-requested a review February 14, 2023 14:31
Copy link
Member

@fiexer fiexer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG!

@fiexer fiexer dismissed stale reviews from shunsukew and andabak February 14, 2023 14:32

blocker

@fiexer fiexer merged commit ed3b48b into main Feb 14, 2023
@fiexer fiexer deleted the feature/build-revamp branch February 14, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants