Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edits-xvm-wasm #260

Merged
merged 2 commits into from
Feb 20, 2023
Merged

edits-xvm-wasm #260

merged 2 commits into from
Feb 20, 2023

Conversation

businj
Copy link
Contributor

@businj businj commented Feb 12, 2023

-WASM to Wasm
-reorganize the beginning of setup your ink environment
-spelling and phrasing

@businj businj requested a review from a team February 12, 2023 21:33
@businj businj requested a review from a team as a code owner February 12, 2023 21:33
@github-actions
Copy link

github-actions bot commented Feb 12, 2023

Visit the preview URL for this PR (updated for commit e7591a9):

https://astar-docs--pr260-edit-xvm-wasm-30mltxii.web.app

(expires Mon, 27 Feb 2023 15:01:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d

Copy link
Member

@andabak andabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to main. This chapter is now under docs/build/builder-guides/ section

-remove repeat sections
-clarity to coding examples when needed
-fix embedded hyperlinks
-remove broken link & and format as tip block (verify-smart-contracts)
-change Remix title to reflect 'Shibuya' guide as we did in other EVM guides
@andabak andabak merged commit e6dd43a into main Feb 20, 2023
@andabak andabak deleted the Edit-xvm-wasm branch February 20, 2023 15:00
gluneau pushed a commit that referenced this pull request Feb 21, 2023
* edits-use-astar-features

-remove repeat sections
-clarity to coding examples when needed
-fix embedded hyperlinks
-remove broken link & and format as tip block (verify-smart-contracts)
-change Remix title to reflect 'Shibuya' guide as we did in other EVM guides

* Update interact_with_wasm_contract.md

---------

Co-authored-by: Ivan <95318860+andabak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants