Remove duplicate text for Remote derive address #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 353f45c): https://astar-docs--pr303-remote-derive-05lc94z7.web.app (expires Wed, 15 Mar 2023 09:39:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d |
Dinonard
requested changes
Mar 8, 2023
Comment on lines
124
to
137
| ### Remotely Derived Contract Address | ||
|
|
||
| For example, let's assume you have a contract deployed on Shibuya and are calling the XCM precompile `remote_transact` with the intention of sending an XCM sequence to a **sibling parachain**. This sibling parachain uses the same address derivation as do our runtimes (described above). The address derivation path will look like this: | ||
|
|
||
| | Name | Address | | ||
| | ---- | ------- | | ||
| | Contract H160 Address | `0x48DD0a20a199f96B56eCE7e994D83614A148aA63` | | ||
| | Contract Derived SS58 Address | `agn53DdEuRgQsvgxqj5M1AecxB6LpbXT7T1R1hjVcoEBR6M` | | ||
| | SS58 Address Public Key | `0xd219fe1b02545c7dd7e718b1530b4e32b23288351f61e5975c7dc49b004ff119` | | ||
| | Caller Multilocation | `{ parents: 1, interior: X2 ( Parachain(2000), AccountId32 {network: NetworkId::Any, id: 0xd219f...f119 } ) }` | | ||
| | Derived Account32Hash Address | `5FrhDFydxUwbWyXT1XDBhRUUYpQtiJJ6skB6n2XV4NubC9fP` | | ||
|
|
||
| This means that the instructions like `WithdrawAsset` and `Transact` will be executed on remote chain as if origin was the address `5FrhDFydxUwbWyXT1XDBhRUUYpQtiJJ6skB6n2XV4NubC9fP`. | ||
|
|
There was a problem hiding this comment.
This one should be kept as it was.
| @@ -101,6 +101,8 @@ To simplify the API via which EVM smart contracts send the `Transact` instructio | |||
|
|
|||
| `DescendOrigin` will ensure that the origin is correctly set to be the smart contract's derived ss58 address. | |||
|
|
|||
| ### Remotely Derived Contract Address | |||
There was a problem hiding this comment.
You should remove content from line 104 up to line 116.
Dinonard
reviewed
Mar 8, 2023
| @@ -133,7 +121,7 @@ For example, let's assume you have a contract deployed on Shibuya and are callin | |||
| | Caller Multilocation | `{ parents: 1, interior: X2 ( Parachain(2000), AccountId32 {network: NetworkId::Any, id: 0xd219f...f119 } ) }` | | |||
| | Derived Account32Hash Address | `5FrhDFydxUwbWyXT1XDBhRUUYpQtiJJ6skB6n2XV4NubC9fP` | | |||
|
|
|||
| This means that the instructions like `WithdrawAsset` and `Transact` will be executed on remote chain as if origin was the address `5FrhDFydxUwbWyXT1XDBhRUUYpQtiJJ6skB6n2XV4NubC9fP`. | |||
| This means that the following instructions like `WithdrawAsset` and `Transact` will be executed as if origin was address `5FrhDFydxUwbWyXT1XDBhRUUYpQtiJJ6skB6n2XV4NubC9fP`. | |||
There was a problem hiding this comment.
They're not following, they have been covered in the previous chapter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.