Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/restructure swanky docs #307

Merged
merged 27 commits into from
Mar 20, 2023
Merged

Feature/restructure swanky docs #307

merged 27 commits into from
Mar 20, 2023

Conversation

codespool
Copy link
Contributor

@codespool codespool commented Mar 13, 2023 •
edited
Loading

Update and restructure Swanky section:

  • create a "swanky" directory
  • split cli and node docs
  • completely restructure cli docs:
    • remove technical docs (provide links to repo readme)
    • apply usage based approach instead of by-command
    • rewrite all the explanations
    • replace outdated gifs with screenshots
    • add 3rd level to TOC

@github-actions
Copy link

github-actions bot commented Mar 13, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit cf1a66f):

https://astar-docs--pr307-feature-restructure-uot8iykv.web.app

(expires Mon, 27 Mar 2023 18:37:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d

@codespool codespool marked this pull request as ready for review March 15, 2023 10:48
@codespool codespool requested a review from a team March 15, 2023 10:48
@codespool codespool requested a review from a team as a code owner March 15, 2023 10:48
@codespool codespool mentioned this pull request Mar 15, 2023
Closed
8 tasks
midegdugarova
midegdugarova approved these changes Mar 15, 2023
View reviewed changes
docs/build/wasm/swanky-suite/cli.md Outdated Show resolved Hide resolved
docs/build/wasm/swanky-suite/cli.md Outdated Show resolved Hide resolved
docs/build/wasm/swanky-suite/index.md Outdated Show resolved Hide resolved
docs/build/wasm/swanky-suite/index.md Outdated Show resolved Hide resolved
andabak
andabak reviewed Mar 16, 2023
View reviewed changes
Copy link
Member

@andabak andabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. No blockers :)

docs/build/wasm/basic-contract.md Outdated Show resolved Hide resolved
docs/build/wasm/basic-contract.md Outdated Show resolved Hide resolved
docs/build/wasm/swanky-suite/index.md Show resolved Hide resolved
docs/build/wasm/swanky-suite/cli.md Show resolved Hide resolved
@codespool codespool merged commit 43b518e into main Mar 20, 2023
@codespool codespool deleted the feature/restructure-swanky-docs branch March 20, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andabak andabak andabak left review comments

@midegdugarova midegdugarova midegdugarova approved these changes

@fiexer fiexer Awaiting requested review from fiexer

@Maar-io Maar-io Awaiting requested review from Maar-io

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codespool @midegdugarova @andabak