Chopsticks & E2E Tests #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 9aef796): https://astar-docs--pr337-chopsticks-fq56wcs5.web.app (expires Tue, 30 May 2023 18:40:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d |
andabak
previously requested changes
May 11, 2023
There was a problem hiding this comment.
General comments:
- You should cross link to Chopsticks documents for more reference (I did not notice this in the text)
- also, based on Learning Session - commenting here but relates to he Astar config file on Chopstick repo - there should be some comments / explanation of Astar config and why it is set up the way it is (DOTs on Alice, USDT on Alice etc) (add as comments in that YAML file for sure)
andabak
reviewed
May 11, 2023
andabak
reviewed
May 11, 2023
|
Updates to comments upstream |
|
It seems that the staging URL is not working on my end. @niklabh Do you know what might be the issue? 
|
impelcrypto
approved these changes
May 23, 2023
|
@impelcrypto Previews dies of natural causes after a while. See the note it leaves in the preview link box
This can be used to look at the page content in the meanwhile: |
sirius651
approved these changes
May 30, 2023
fiexer
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefits of using chopsticks and examples of CLI