Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update about astar page #47

Merged
merged 4 commits into from
Aug 9, 2022
Merged

doc: update about astar page #47

merged 4 commits into from
Aug 9, 2022

Conversation

sugurujames
Copy link
Contributor

Added a small description and a developer incentive section in about astar page as this was mentioned from @SotaWatanabe

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

Visit the preview URL for this PR (updated for commit a721764):

https://astar-docs--pr47-feat-about-astar-mk3vp9sl.web.app

(expires Tue, 16 Aug 2022 15:11:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@@ -25,3 +26,6 @@ Scalability on the Astar Network is addressing the followings topics:
Many different blockchains exist but few have interoperability as a feature. To move "value" from Bitcoin to Ethereum, we need a centralized exchange. Polkadot is a sharded protocol that enables blockchain networks to operate together seamlessly.

[Astar Network] is compatible with Polkadot. By connecting Astar Network to Polkadot, we will have true interoperability.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds a little bit outdated - "By connecting Astar to Polkadot we will have true interoperability" - maybe rephrase to present tense (I assume this text is from pre-winning parachain slot time)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback. I agree with your opinion and changed it to present tense.

@sugurujames sugurujames removed the request for review from hoonsubin August 9, 2022 13:07
@sugurujames
Copy link
Contributor Author

@andabakus I appreciate if you can approve this PR too. I made a necessary change.

Copy link
Member

@andabak andabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sugurujames sugurujames merged commit 96dfd22 into main Aug 9, 2022
@sugurujames sugurujames deleted the feat/about-astar branch August 9, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants