Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenomics 2.0 docs #553

Merged
merged 8 commits into from
Dec 29, 2023
Merged

Tokenomics 2.0 docs #553

merged 8 commits into from
Dec 29, 2023

Conversation

Dinonard
Copy link
Member

Added documentation covering Tokenomics 2.0 model.

  • formulas with inflation calculation breakdown
  • staker reward calculation formula
  • joined together legacy & hybrid inflation docs

@Dinonard Dinonard requested review from a team as code owners December 27, 2023 14:58
@Dinonard Dinonard added the documentation Improvements or additions to documentation label Dec 27, 2023
Copy link

github-actions bot commented Dec 28, 2023

Visit the preview URL for this PR (updated for commit e7e3c7a):

https://astar-docs--pr553-feat-tokenomics-2-4908ysti.web.app

(expires Fri, 05 Jan 2024 10:39:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d

docs/learn/index.md Show resolved Hide resolved
`BuildAndEarn` subperiod consists of one or more **eras**. Each era has a fixed length.
`Voting` subperiod always consists of exactly **one era** but its length can be longer than a standard era length.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is confusing. It is not incorrect, but still thinking how to write it simpler.

Why can't you write (for the sake of better understanding):

Voting subperiod always consists of exactly one era and this 'voting era' is unique as its length can be longer than a standard era length (it has more blocks than standard era).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have anything against changing how it's written but you should also emphasize that the length is of the Voting subperiod is a multiple of standard era length.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted please check

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with it if it's more clear for you.

docs/learn/tokenomics2/Inflation.md Outdated Show resolved Hide resolved
docs/learn/tokenomics2/Inflation.md Outdated Show resolved Hide resolved
docs/learn/tokenomics2/Inflation.md Show resolved Hide resolved
docs/learn/tokenomics2/Inflation.md Outdated Show resolved Hide resolved
docs/learn/tokenomics2/Inflation.md Outdated Show resolved Hide resolved
docs/learn/tokenomics2/Inflation.md Outdated Show resolved Hide resolved
docs/learn/tokenomics2/Inflation.md Outdated Show resolved Hide resolved
docs/learn/tokenomics2/Inflation.md Show resolved Hide resolved
@andabak andabak self-requested a review December 29, 2023 10:21
Copy link
Member

@andabak andabak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dinonard Dinonard merged commit 2be5243 into main Dec 29, 2023
3 checks passed
@Dinonard Dinonard deleted the feat/tokenomics-2 branch December 29, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants