Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidating dApp Staking v3 docs #568

Merged
merged 5 commits into from Jan 10, 2024
Merged

Conversation

andabak
Copy link
Member

@andabak andabak commented Jan 9, 2024

Based on this issue #558

I did not change nomenclature (e.g. build2ear) but moved forward to

  • add relevant info about dappstaking v3 in LEARN section
  • remove build2earn from LEARN section (redundant)

TODO in future PR

  • update BUILD section (Decide what is redundant) and update naming convetntion

File docs/learn/dapp-staking.md is verbatim copied to docs/learn/dapp-staking-v3/dapp-staking-protocol.md

@andabak andabak added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Jan 9, 2024
@andabak andabak self-assigned this Jan 9, 2024
@andabak andabak requested review from a team as code owners January 9, 2024 11:39
Copy link

github-actions bot commented Jan 9, 2024

Visit the preview URL for this PR (updated for commit ecc6bde):

https://astar-docs--pr568-feat-consolidate-dap-pcwaws9f.web.app

(expires Wed, 17 Jan 2024 08:33:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d

Ivan Andrisek and others added 3 commits January 9, 2024 12:57
Fix typo and add forum link
I removed your username from the params in the URL
@andabak
Copy link
Member Author

andabak commented Jan 9, 2024

@Dinonard once this PR is merged, document /docs/learn/dapp-staking.md will be obsolete and changes should be made to /docs/learn/dapp-staking-v3/dapp-staking-protocol.md file

docs/learn/dapp-staking-v3/dapp-staking-faq.md Outdated Show resolved Hide resolved
docs/learn/dapp-staking-v3/index.md Outdated Show resolved Hide resolved
docs/learn/dapp-staking-v3/index.md Outdated Show resolved Hide resolved
docs/learn/dapp-staking-v3/dapp-staking-faq.md Outdated Show resolved Hide resolved
@andabak
Copy link
Member Author

andabak commented Jan 10, 2024

@Dinonard addressed your comments. Thanks!

@andabak andabak merged commit d12039e into main Jan 10, 2024
3 checks passed
@andabak andabak deleted the feat/consolidate-dappstaking-v3 branch January 10, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants