Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dApp Staking V3 User Guides #576

Merged
merged 8 commits into from Jan 19, 2024
Merged

dApp Staking V3 User Guides #576

merged 8 commits into from Jan 19, 2024

Conversation

Gunit2481
Copy link
Contributor

  • Moved dApp Staking from Build to Use Category
  • Moved old dApp Staking v2 guide & images under dApp Staking section;
  • Added dApp Staking v3 User guide & images;
  • Updated all links to dApp Staking section;
  • Organized Use Category Sidebar;
  • Ran Yarn build without errors;

@Gunit2481
dApp Staking V3 User Guides
d9ef60c 
- Moved dApp Staking from Build to Use Category
- Moved old dApp Staking v2 guide & images under dApp Staking section;
- Added dApp Staking v3 User guide & images;
- Updated all links to dApp Staking section;
- Organized Use Category Sidebar;
- Ran `Yarn build` without errors;
@Gunit2481 Gunit2481 requested review from a team as code owners January 16, 2024 08:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2024 •
edited

Visit the preview URL for this PR (updated for commit faa8735):

https://astar-docs--pr576-dapp-staking-v3-guid-jelr4284.web.app

(expires Thu, 25 Jan 2024 15:16:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d

@Gunit2481
Added V2 users warning message
5af9932 
- Addition of a warning message to inform that V3 is only available on Shibuya and invite V2 users to visit the dApp Staking V2 category.
- Fixed a few typo;
Dinonard
Dinonard reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the dApp staking perspective, important things are periods, subperiods and eras.

Cycles are only relevant for the inflation.

I suggested some changes, but other file might also require renaming:

  • cycle -> subperiod
  • period -> subperiod

docs/use/dapp-staking/for-devs/requirements.md Outdated Show resolved Hide resolved
docs/use/dapp-staking/for-stakers/index.md Outdated Show resolved Hide resolved
docs/use/dapp-staking/for-stakers/index.md Outdated Show resolved Hide resolved
docs/use/dapp-staking/for-stakers/index.md Outdated Show resolved Hide resolved
docs/use/dapp-staking/for-stakers/index.md Outdated Show resolved Hide resolved
docs/use/dapp-staking/for-stakers/index.md Outdated Show resolved Hide resolved
docs/use/dapp-staking/for-stakers/index.md Outdated Show resolved Hide resolved
docs/use/dapp-staking/for-stakers/staking.md Outdated Show resolved Hide resolved
docs/use/dapp-staking/for-stakers/unstaking.md Outdated Show resolved Hide resolved
docs/use/dapp-staking/for-stakers/manage-dApp-Staking.md Outdated Show resolved Hide resolved
andabak
andabak requested changes Jan 17, 2024
View reviewed changes
docs/use/dapp-staking/index.md Outdated Show resolved Hide resolved
docs/use/dapp-staking/index.md Show resolved Hide resolved
docs/use/dapp-staking/index.md Outdated Show resolved Hide resolved
docs/use/dapp-staking/dapp-staking-v2/index.md Outdated Show resolved Hide resolved
docs/use/dapp-staking/for-stakers/index.md Outdated Show resolved Hide resolved
docs/use/dapp-staking/for-stakers/index.md Outdated Show resolved Hide resolved
docs/use/dapp-staking/for-stakers/index.md Outdated Show resolved Hide resolved
docs/use/dapp-staking/for-stakers/index.md Outdated Show resolved Hide resolved
docs/use/dapp-staking/for-stakers/unstaking.md Show resolved Hide resolved
bobo-k2
bobo-k2 reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that you took pictures from Figma because UI styling is not ready yet. A lot of stylings have been improved in last few days. so please check the portal after next release and see if you can use the portal screenshots.

docs/use/dapp-staking/for-stakers/move-staked-tokens.md Outdated Show resolved Hide resolved
@Kahonnohak
Copy link
Contributor

Kahonnohak commented Jan 18, 2024 •
edited

We are using Unbond in UI but we say locked tokens which is confusing. The technical call is lock and unlock, unbond is no longer used. So lets use "unlock" for user guides/UI too. Then no confusion for "unlock". Unlock in UI means unstake and unlock but we all do it at once hence no "unstake" as a user action. Unstake happens only at the end of Build&Earn period)

Unlock instead of unbond. We have Vote (&stake) <-> unlock (Astar has 10 unlocking days). Will change the wording in UI too.

@Kahonnohak
Copy link
Contributor

Kahonnohak commented Jan 18, 2024 •
edited

Hi @Gunit2481
Before you go through How to stake, I thought it was a good idea to have the rule (or Summary). Otherwise it is difficult to how it works?

(this image is an old draft so there are some incorrect info)

Screenshot 2024-01-18 at 11 31 02

@Gunit2481
Updated User Guide - v2
ed548c5 
- Resolved conflicts with PR 573;
- Re-added a dApp Staking page under Build section;
- Moved integrate dApp Staking page to Build/dApp-staking page;
- Fixed typo;
- Added suggestions;
- Changed and enlarged images;
- Changed every unbond & unbonding to unlock & unlocking;
- Removed all mentions of Build2Earn;
@Gunit2481 Gunit2481 added the documentation Improvements or additions to documentation label Jan 18, 2024
@andabak andabak merged commit a38d806 into main Jan 19, 2024
3 checks passed
@andabak andabak deleted the dApp-Staking-V3-guides branch January 19, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinonard Dinonard Dinonard left review comments

@bobo-k2 bobo-k2 bobo-k2 left review comments

@andabak andabak andabak approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Gunit2481 @Kahonnohak @Dinonard @bobo-k2 @andabak