New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add V3 Technical Architecture and Design doc to the build section #590
Conversation
Visit the preview URL for this PR (updated for commit e47af35): https://astar-docs--pr590-ds-v3-technical-desi-t7w43jhd.web.app (expires Thu, 15 Feb 2024 13:53:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewd 1/3 of the doc but believe this shouldn't be put into the docs.
I just don't believe the format is good.
The purpose behind the source doc was for me to have a single source of information & decisions we/I made. Sort of a reference for implementation.
Let's consider an alternative approach.
I honestly feel this will bring more confusion than information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few suggestions, but overall, lgtm.
Co-authored-by: Gaius_sama <85451570+Gunit2481@users.noreply.github.com>
Co-authored-by: Gaius_sama <85451570+Gunit2481@users.noreply.github.com>
Co-authored-by: Gaius_sama <85451570+Gunit2481@users.noreply.github.com>
--- | ||
|
||
:::important | ||
The target audience for this page are developers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The target audience for this page are developers building projects which interact with dApp Staking protocol.
Just a suggestion to clearly drive away those who fall into category /use/for-devs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor nice-to-have comment
No description provided.