Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zkEVM User Guides 2 #649

Merged
merged 6 commits into from Mar 22, 2024
Merged

zkEVM User Guides 2 #649

merged 6 commits into from Mar 22, 2024

Conversation

Gunit2481
Copy link
Contributor

  • Add from Astar zkEVM to Astar EVM bridge
  • Add from Astar zkEVM to Ethereum
  • Add unstaking vASTR on Astar zkEVM
  • Improve images
  • Add JP translations

Gunit2481 and others added 4 commits March 19, 2024 19:35
@Gunit2481
Update
e8b546c 
- Add from Astar zkEVM to Astar EVM bridge
- Add from Astar zkEVM to Ethereum
- Add unstaking vASTR on Astar zkEVM
- Improve images
@Gunit2481
Update ASTR-Liquid-Staking.md
f87722c
@tksarah
Update zkEVM-guides for JP (#648)
c0b531b
@Gunit2481
Add DOT address
363e808
@Gunit2481 Gunit2481 added documentation Improvements or additions to documentation translation labels Mar 21, 2024
@Gunit2481 Gunit2481 requested review from a team as code owners March 21, 2024 17:10
meganskye
meganskye reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@meganskye meganskye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please confirm JP doc is complete & does not contain any duplicate info now that conflicts have been resolved.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited

Visit the preview URL for this PR (updated for commit 2c8c1d7):

https://astar-docs--pr649-zkevm-user-guides-2-h3vlmif3.web.app

(expires Fri, 29 Mar 2024 12:31:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d

@tksarah
Copy link
Contributor

tksarah commented Mar 21, 2024

Good morning! I have checked these on staging.

Bridge-Ethereum
It seems there are many mistakes in “Bridge-Ethereum”
It appears that significant corrections are necessary.

  • Layerswap section has bug
  • Relay Link section is duplicated
  • insert a line break after ‘:::info'.

Bridge-Astar-EVM:
Line 27
Current "### Astar EVMからAstar zkEVMへ"
Update "### Astar EVMからAstar zkEVMへ:"

ASTR-Liquid-Staking:
LGTM!

@tksarah
Copy link
Contributor

tksarah commented Mar 22, 2024

I have checked again.

Bridge-Ethereum
Insert a line break after the word ‘info’ on line 68.

Current:

:::info 転送は、Ethereum ネットワークの使用状況により、10 分から 30 分かかることがあります。

Update:

:::info
転送は、Ethereum ネットワークの使用状況により、10 分から 30 分かかることがあります。

I’ve noticed an error in the original English version. It seems there is a “3.” in the Relay Link section.

スクリーンショット 2024-03-23 002918

Apart from these, it looks good to me (LGTM).

meganskye
meganskye approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@meganskye meganskye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! lgtm!

@meganskye meganskye merged commit 18e7bec into main Mar 22, 2024
3 checks passed
@meganskye meganskye deleted the zKEVM-User-Guides-2 branch March 22, 2024 15:49
@tksarah tksarah mentioned this pull request Apr 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meganskye meganskye meganskye approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gunit2481 @tksarah @meganskye