Use linkspector #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 7 7
=========================================
Hits 7 7 ☔ View full report in Codecov by Sentry. |
teutoburg
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
LGTM! Certainly good to have a more up-to-date (and maintained) version of this that works for all cases. Probably this now means we have to call this DevOps in every other repo, AFAIK we're just calling the old one everywhere, and not refer to this in DevOps...
|
Yeah, it is now clear that even if it wouldn't save much lines of code, it would still have been useful to refer to this workflow from the beginning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use linkspector instead of markdown-link-check
markdown-link-check does not work with the new redirection scheme of SPIE, see AstarVienna/ScopeSim#322
The creator the github action we used to use, states that we should move to linkspector: https://github.com/gaurav-nelson/github-action-markdown-link-check
See #10 to see how the action looks for a broken link.