Merge pull request #343 from AstarVienna/hb/importall

Add test to see whether all Python files can be imported.

scopesim/detector/nghxrg.py

@@ -10,7 +10,7 @@
 # import warnings
 
 import numpy as np
-from scipy.ndimage.interpolation import zoom
+from scipy.ndimage import zoom
 from astropy.io import fits
 from astropy.stats.funcs import median_absolute_deviation as mad
 
@@ -199,7 +199,7 @@ def pink_noise(self, mode):
         """
 
         # Configure depending on mode setting
-        if mode is 'pink':
+        if mode == 'pink':
             nstep = 2*self.nstep
             f = self.f2
             p_filter = self.p_filter2

scopesim/tests/test_import_all.py

@@ -0,0 +1,26 @@
+"""Test whether all Python files can be imported."""
+import importlib.util
+import time
+from pathlib import Path
+
+import scopesim
+
+
+def test_import_all():
+    """Test whether all Python files can be imported.
+
+    This ensures that all files are included in the code coverage.
+    """
+    for name_path_scopesim in scopesim.__path__:
+        path_scopesim = Path(name_path_scopesim)
+        fns_python = path_scopesim.glob("**/*.py")
+        for fn in fns_python:
+            name_package = ".".join(fn.relative_to(path_scopesim.parent).with_suffix("").parts)
+            time_1 = time.time()
+            importlib.import_module(name_package)
+            time_2 = time.time()
+            time_delta = time_2 - time_1
+            msg = f"{name_package} takes {time_delta} seconds to import"
+            # Assert the package is quick to import, because this can highlight
+            # broken packages. Requires running this test in isolation.
+            assert time_delta < 0.2, msg

scopesim/tests/tests_server/test_database.py

@@ -18,6 +18,12 @@ def mock_client():
         yield client
 
 
+@pytest.fixture(scope="class")
+def all_pkg():
+    # TODO: This could use some kind of mock to avoid server access
+    yield db.get_all_package_versions()
+
+
 @pytest.mark.webtest
 def test_package_list_loads():
     with pytest.warns(DeprecationWarning):
@@ -40,22 +46,20 @@ def test_get_all_latest():
 
 @pytest.mark.webtest
 class TestGetZipname:
-    # TODO: This could use some kind of mock to avoid server access
-    all_pkg = db.get_all_package_versions()
 
-    def test_gets_stable(self):
-        zipname = db._get_zipname("test_package", "stable", self.all_pkg)
+    def test_gets_stable(self, all_pkg):
+        zipname = db._get_zipname("test_package", "stable", all_pkg)
         assert zipname.startswith("test_package.")
         assert zipname.endswith(".zip")
 
-    def test_gets_latest(self):
-        zipname = db._get_zipname("test_package", "latest", self.all_pkg)
+    def test_gets_latest(self, all_pkg):
+        zipname = db._get_zipname("test_package", "latest", all_pkg)
         assert zipname.startswith("test_package.")
         assert zipname.endswith(".dev.zip")
 
-    def test_throws_for_nonexisting_release(self):
+    def test_throws_for_nonexisting_release(self, all_pkg):
         with pytest.raises(ValueError):
-            db._get_zipname("test_package", "bogus", self.all_pkg)
+            db._get_zipname("test_package", "bogus", all_pkg)
 
 
 @pytest.mark.webtest