Skip to content

Commit

Permalink
resolved conflict from dev_master
Browse files Browse the repository at this point in the history
  • Loading branch information
astronomyk committed Jan 31, 2024
2 parents 340fbd4 + 7a6d735 commit b82961c
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions scopesim/effects/ter_curves.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,12 +205,10 @@ def plot(self, which="x", wavelength=None, *, axes=None, **kwargs):
wunit = params["wave_unit"]
# TODO: shouldn't need both, make sure they're equal
if wunit != wave_unit:
logger.warning("wavelength units in the meta dict of "
"%s are inconsistent:\n"
"- wavelength_unit : %s\n"
"- wave_unit : %s",
{self.meta.get("name")},
wave_unit, wunit)
logger.warning(f"wavelength units in the meta dict of "

Check warning on line 208 in scopesim/effects/ter_curves.py

View check run for this annotation

Codecov / codecov/patch

scopesim/effects/ter_curves.py#L207-L208

Added lines #L207 - L208 were not covered by tests
f"{self.meta.get('name')} are inconsistent: \n"
f"- wavelength_unit : {wave_unit} \n"
f"- wave_unit : {wunit}")

wave = np.arange(quantify(params["wave_min"], wunit).value,
quantify(params["wave_max"], wunit).value,
Expand All @@ -223,7 +221,7 @@ def plot(self, which="x", wavelength=None, *, axes=None, **kwargs):
abbrs = {"t": "transmission", "e": "emission",
"r": "reflection", "x": "throughput"}

if not isinstance(axes, Iterable):
if not isinstance(axes, list):
axes = [axes]

Check warning on line 225 in scopesim/effects/ter_curves.py

View check run for this annotation

Codecov / codecov/patch

scopesim/effects/ter_curves.py#L224-L225

Added lines #L224 - L225 were not covered by tests
for ter, ax in zip(which, axes):
y_name = abbrs.get(ter, "throughput")
Expand Down

0 comments on commit b82961c

Please sign in to comment.