Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MICADO grating efficiencies #214

Closed
oczoske opened this issue Jun 1, 2023 · 0 comments
Closed

MICADO grating efficiencies #214

oczoske opened this issue Jun 1, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@oczoske
Copy link
Collaborator

oczoske commented Jun 1, 2023

Needs to be a new effect - sort of a transmission per spectral trace, needs to be applied to the FOV before mapping to the XiLamImage. There is an effect MetisLMSEfficiency (branch oc/spectraces_lms), but that computes the efficiency for the wavelength setting and then applies it to all traces. For MICADO, the efficiencies can be read from a file but must be applied for each trace separately. A possible solution would be to build the grating efficiency into the SpectralTraceList effect, However, as long as the FOVs are uniquely identified with a trace, a standalone effect should work and would be more in line with the basic idea of Effects.

@oczoske oczoske added the enhancement New feature or request label Jun 1, 2023
@oczoske oczoske closed this as completed Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant