v0.5.3 #165
Merged
v0.5.3 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring new univie server URL into dev_master
Kl/test ifu
…ment Add basic instrument mock files to MANIFEST
…into dev_master
Use number of detector in FITS keywords
Kl/docs cleanup 3
hugobuddel
reviewed
Sep 23, 2022
|
If @wjvriend is okay with this version, then it is fine with me too! |
|
I'm okay with this version! |
|
Green now. The only failing test was because of the SVO Filter service rate limiter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScopeSim v0.5.3 update
@hugobuddel : I have requested you review this, but only do so if you really want to 😉
The purpose of this minor merge is to transfer everything that we have done since April 2022 into the master branch, and then compile and publish a new version to Pypi.
The new version of scopesim is need by the MicadoWISE team so that they have a a stable development environment with a version of scopesi that contains all the FITS keyword functionality that they require
Changes
The vast majority of additions/deletions are either docstrings or formatting changes. There are only minor changes to the code base in this version:
ExtraFitsKeywordsnow has the ability to add keywords with incrementing index numbers based on the extension numberFOV+FOVManager+FOVVolumesclasses now acceptaperture_idas an argument, so that IFU / MOS instruments can me setup using the same structure as the LSS systemsApertureListeffects object now has anapply_tofunction which splits the FOVVolumeList accordingly. This is useful for MOS's, but not so much for IFUs as it shrinks the the FOV size to exactly that of the Apertures, and therefore ignores any sources just outside the slits/apertures. This currently is a work in progress, but is used by the basic_instrument IFU mode.